General question, when there is a

TODO

in the code base like this one here, is it reasonable to assume that this would be open to a PR from a contributor? Or would you still expect a Github issue to be made to discuss it in detail first? I ask, as the contributor guidelines state that Metaflow is open to small PRs without an initial Github issue. If that is too generic a question to answer for the general case (which I appreciate might well be the case 🙂 ) then how about this particular instance? Would you prefer an issue to discuss refactoring this particular function?

@mammoth-rainbow-82717 for a small and non-invasive PR, it’s okay to start with a PR. For this particular case, it would be best to have a short discussion to align on the nature of the change.

ok, cool. Makes sense.

Please feel free to open new issues 🙂 We are always happy to discuss how the code base can be further improved upon!

cool. I'll have a think and put some ideas down in an issue.