We ran into an issue with setting node selectors w...
# dev-metaflow
q
We ran into an issue with setting node selectors with kubernetes decorators, resulting from the
=
in the
node_selector
value, e.g.
node_selector=["<http://node.kubernetes.io/instance-type=g5.xlarge|node.kubernetes.io/instance-type=g5.xlarge>"]
. I have created this PR which fixed the issue in our case. https://github.com/Netflix/metaflow/pull/1197
👀 1
1
a
thanks for the PR! We can ship this after tests pass.
q
Great! Thanks for the quick turnaround. cc @calm-energy-78015
🙌 1
a single test failed on MacOS python 3.8 only, but nflx-mf-bot seems to think it passed anyway. @square-wire-39606 Any idea whether this is something I should fix, or maybe an intermittent issue with testing infrastructure?
a
I will retry the tests and cut a release later today
🙏 2
q
yay, thank you! happy to see that tests passed this time around