https://outerbounds.com/ logo
Join Slack
Powered by
Hi team, I submitted a couple PRs to <metaflow> an...
# dev-metaflow
c
Hi team, I submitted a couple PRs to metaflow and metaflow-doc for some spelling, grammar, typo things I noticed. Is there anything else I need to do to get some eyes on it? Cheers!
✅ 1
v
this is great, thanks a ton! 🤗 We will review and merge (and comment if there's anything that requires more attention from you)
c
Awesome, I look forward to some more functional contributions down the road.
v
amazing, thanks! If you have any bigger ideas in mind, open a thread in advance to discuss and plan it. Smaller changes and docs changes like this PR are easier to merge as-is. It's always a bit challenging if a big functional PR lands out of the blue. Talking and aligning first helps a ton! 😊
c
Absolutely- I did take note of that in the contribution guidelines. As 99% non-functional changes, I took my chances on this one. 🙂
v
yep, looks very nice 👌
c
BTW, is there a description of the git flow the project follows? The default branch is master and I didn't see develop, so I wasn't sure.
a
@clean-school-46881 - quick comment on the PR - can you exclude the 
metaflow/_vendor
folder - that folder is auto-generated from the packages we intend to vendor and would like them to remain untouched.
c
Oh okay, sure.
a
Otherwise, the PR looks good to go!
in terms of git-foo - we merge to and release from master
c
Sounds good- I’ll open PRs straight there, then.
👍 1
I thought 
black
was supposed to fix things prior to merging, not throw errors where it’s not in compliance… What is your workflow when raising a PR?
a
We manually run 
black
prior to raising a PR
👍 1
c
You must skip the _vendor folder then, because running 
black ./
does change some code there.
a
Yeah - we usually just run black on the files that are included in the diff
👍 1
c
Thanks for the help- I’m sure this will go smoother from me next time.
among us party 1
Open in Slack
PreviousNext
Powered by