Sanity check: <https://github.com/Netflix/metaflow...
# ask-metaflowm
mammoth-rainbow-82717
10/18/2023, 11:11 AMSanity check: https://github.com/Netflix/metaflow/blob/master/metaflow/plugins/argo/argo_workflows.py#L441 - Should this check cover just required parameters? I think it will need to cover for non-required parameters too, but wanted to confirm.
✅ 1
a
ancient-application-36103
10/18/2023, 3:05 PMcorrect - only the required parameters need to have a default value set for scheduled workflows
m
mammoth-rainbow-82717
10/18/2023, 3:08 PMI think Argo Workflows expects all parameters to have a value though, so if it is not defined in the workflow directly it is expected to be passed in at runtime, e.g., through the UI.
mammoth-rainbow-82717
10/18/2023, 3:09 PMI mean, Argo has no concept of the parameter being required or not on the Metaflow side.
mammoth-rainbow-82717
10/18/2023, 3:09 PMSo I think non-required parameters without a default will also fail when put on a schedule
a
ancient-application-36103
10/18/2023, 5:00 PMyes - we set a default for the non-required parameters without a default
ancient-application-36103
10/18/2023, 5:01 PMm
mammoth-rainbow-82717
10/18/2023, 5:17 PMum.....this isn't coming through in the examples I have checked.
mammoth-rainbow-82717
10/18/2023, 5:17 PMLet me double check and get back to you
👍🏼 1
mammoth-rainbow-82717
10/27/2023, 3:54 PMTurned out it was a bug on our end btw. My bad, sorry about that.
5 Views