https://outerbounds.com/ logo
Join Slack
Powered by
Hello I'm looking to upgrade my version of the me...
# ask-metaflow
m
Hello I'm looking to upgrade my version of the metaflow service. This guide requires calling commands such as 
python3 migration_tools.py db-status --base-url <http://xxx.xxx.xxx.xxx:8082>
. However, it seems that the file 
migration_tools.py
is not added to the docker image for the metaflow-service. Am I missing something? Or the docs are old?
✅ 1
I guess maybe one is meant to use the 
run_goose.py
functionality instead?
Looking through the code it seems that they have largely the same functionality. I assume the 
migration_tools.py
is old. If so, would be good to update the docs (and I guess remove that old file?).
a
Hi Thomas! 
migration_tools.py
invokes an api endpoint exposed by the docker container (the migration service). As such the expected behavior is that this script will be used from outside and is not bundled in the docker image
the API endpoint in turn invokes the 
run_goose.py
file
of course, you can also invoke 
goose
manually and forego this contraption of 
migration_tools.py
m
I see. I understand now. Running goose manually was the approach I've decided to take.
Thanks for the help!
FYI - https://github.com/Netflix/metaflow-service/blob/master/setup.py#L25 The version number in the setup.py seems to be out of sync. I think the current version is 2.4.3.
a
good catch! would you like to submit a PR?
m
of course, no probs. I'll do it in the morning. 🙂
FYI, here is the PR. I guess it will be necessary to delete the incorrect tag and republish. I don't have permission to do that, obviously. 🙂
btw, one other minor thing I noticed. The 
dockerimage
Github action in this repo seems to have some pretty old pins to the 
checkout
and 
build-push-action
actions. https://github.com/Netflix/metaflow-service/blob/master/.github/workflows/dockerimage.yml#L14 This is resulting in some warnings on the action runs - https://github.com/Netflix/metaflow-service/actions/runs/5685654496
Happy to make an issue for this, if you like.
a
for sure! or if you would like to just go ahead and fix them, that will be highly appreciated 🙏🏼
🙌 1
7 Views
Open in Slack
PreviousNext
Powered by