Hey everyone -- is there a particular process we s...
# dev-metaflow
m
Hey everyone -- is there a particular process we should go through to submit a PR to the
metaflow
project? I've read (and tried to follow) the
CONTRIBUTING.md
instructions, but have yet to get a response from anyone about it.
1
s
hey guillermo, we recommend proposing and discussing contributions in this channel - ideally before writing any line of code. the rough dev process we follow today is - 1. memo of proposed functionality (usually a google doc) 2. proof-of-concept implementation (can be a throw-away implementation) 3. refinement into a release ready implementation 4. release
we are bandwidth constrained for code reviews, so we prioritize code reviews that are either bug fixes or follow the dev model outlined above.
m
Ah lovely -- I appreciate the response and guidance! Completely understand the constrained bandwidth and glad to see there's a nice process I can follow~ Should the proposed functionality memo have a certain structure? Or just something logically follow-able?
s
the later
usually it would be good to call out - 1. user stories 2. constraints 3. implementation proposal 4. impact to UX and/or performance
👍 1
m
Perfecto -- I'll go ahead and put something together. When I've got it ready, should I link it in this thread or start a new one?
s
if you can start a new thread in #C020U025QJK that will be super!
❤️ 1
m
Will do! Thanks again for the guidance -- very much appreciated~
yayfox 1