Question about gauging interest in submitting a fi...
# dev-metaflowp
prehistoric-salesclerk-95013
02/13/2025, 7:26 PMQuestion about gauging interest in submitting a fix for this issue from 2022. That's the Argo Workflows custom metrics that we'd like to expose to the metaflow framework. It came up 3 times in slack search (2022, 2023, 2024) but as far as I can tell, it's still a TODO in plugins/argo.py
a
ancient-application-36103
02/13/2025, 7:28 PMwhat kind of metrics would be useful?
p
prehistoric-salesclerk-95013
02/13/2025, 7:30 PMwe have workflows that would like to persist some values into prometheus from things-inside-the-flow, like the number of nulls filtered out in a particular part of the flow. In the past we've used a prometheus pushgateway to get these into prometheus, and we're adding otel events, but the whole Argo Workflows custom metrics setup is a much better fit with fewer moving parts for the type of metrics we need to collect.
prehistoric-salesclerk-95013
02/13/2025, 7:30 PMbeing more specific, a particular inference flow wants to be able to emit business metrics that we have in our regular prometheus. These are already running through Argo Workflows
a
ancient-application-36103
02/13/2025, 7:32 PMi see - would something of this sorts suffice
ancient-application-36103
02/13/2025, 7:34 PMotherwise, for enhancements, our process has been to write a memo detailing the problem, ux and implementation approach before beginning on a POC. let us know if you would like to take this up!
p
prehistoric-salesclerk-95013
02/13/2025, 7:34 PMThat's more or less what we've done with the prometheus pushgateway, and I don't mind the interface in metaflow-measure, I just wish it was a wrapper around argo workflow's
metrics: