hi all, it seems that the Metaflow-to-Airflow conv...
# dev-metaflow
q
hi all, it seems that the Metaflow-to-Airflow conversion process loses any k8s tolerations that were configured on the steps. I was poking at the codebase and it looks like this function does not actually configure tolerations anywhere? Someone please correct me if I am wrong or if there is another step where they should be configured.
Copy code
def _kubernetes_pod_operator_args(operator_args):
    from kubernetes import client

    from airflow.kubernetes.secret import Secret

    # Set dynamic env variables like run-id, task-id etc from here.
    secrets = [
        Secret("env", secret, secret) for secret in operator_args.get("secrets", [])
    ]
    args = operator_args
    args.update(
        {
            "secrets": secrets,
            # Question for (savin):
            # Default timeout in airflow is 120. I can remove `startup_timeout_seconds` for now. how should we expose it to the user?
        }
    )
a
yes - that's expected. we haven't ported the entire feature set to airflow yet, but it is easy to add in. @thankful-ambulance-42457 can you look into this?
👍 1
q
cc: @red-accountant-23764
Thanks! We can also take a stab at a PR
There is a few other things I noticed too - mostly related to type hints being in correct in the kubernetes decorator, can open a PR since it's a minor thing, but can be annoying for end-users
a
Yes please - much appreciated thankyou