Hi folks! I’ve noticed a credential leak issue in ...
# ask-metaflow
c
Hi folks! I’ve noticed a credential leak issue in
metaflow-nflx-extensions
when resolving mixed conda/pypi environments against a private index using embedded credentials. Unlike pure conda or pypi environments (which strip credentials properly), mixed environments preserve auth tokens from the private index URL and leak them into the datastore URI. Example: • Index URL:
<https://user:token@private-pypi.example.com/simple/>
• Datastore URI:
<gs://some_bucket/backend/conda_env/packages/pypi/user:token@private-pypi.example.com/packages/some_private_package>
I think I've tracked this back to the
conda-lock
invocation here. Passing the
--strip-auth
flag might resolve it, assuming that auth isn't explicitly needed downstream. If it is, stripping the credentials during
make_partial_cache_url
would be a great alternative. While I can personally work around this using a different auth pattern like
.netrc
, I’m building tooling for a broader team and need to ensure their credentials stay out of plaintext regardless of their auth method. Let me know if you need any more details or if I've missed anything!
d
hello — thank you for the bug report. It’s quite possible we missed this 😞. That is indeed not great at all. It should not be needed elsewhere (well it may be needed to download stuff but definitely not in the datastore URL) so we’ll get a fix out for it.
c
No worries, happy to open an Issue or PR if that's helpful. Thanks for the quick acknowledgement
Is there any help I can provide here? I can see the PR for this fix might have stalled.
d
we have the PR right — https://github.com/Netflix/metaflow-nflx-extensions/pull/78. We need to fix the tests. We will try to get it in soon. Feel free to update it though if you have things to contribute.