Hello team! Would love some 👀 from the maintainers on this one and happy to send a PR if you all agree with the direction and approach. https://github.com/Netflix/metaflow/issues/3228

Yes, sounds good to me. Will respond in the issue thread as well

Perfect! Really appreciate it! We will put up a PR soon

@thankful-ambulance-42457 / @ancient-application-36103 might need you all to take a look as well

Thanks for the comment, will update that bit! Let me know if you all have thoughts on the behavioral comment I left

@thankful-ambulance-42457 / @ancient-application-36103 can you take a look at the approach? I already reviewed the PR, but there's still a question re backwards compatibility

I took a look and posted some thoughts in the PR yesterday, but to reiterate here in summary, I'm not sure if the fallback-feature-flag is necessary in most use cases. Simply offering an env var to configure the service name through, with

metaflow

as the default for backwards compatibility should be enough 1. If a user/org wants to use an already configured

OTEL_SERVICE_NAME

in their environment, then they still need to add a new entry to their Metaflow profile to enable this. The edit could just as well be to change the service name through the config at that point. 2. If the org wants the ability to set/swap service names as part of their infra instead of Metaflow profiles, and they are managing environment variables separately, then this should only require an additional

METAFLOW_OTEL_SERVICE_NAME=$OTEL_SERVICE_NAME

to the runtime environments in order to override the defaults. What would be the scenario where being able to control the service name inheritance through the Metaflow profile is strictly required compared to the alternative of setting the service name directly? The user wanting name inheritance but not knowing the correct name at deploy time? I'm not seeing a huge benefit for the added complexity, so leaning towards only offering

METAFLOW_OTEL_SERVICE_NAME

as an option for simplicity.

Thanks so much for reviewing it! I will come back to this by lunch.

excellent. Merged now 👌

Thanks Sakari. Thanks @red-rainbow-11418 for the contribution

thanks all! i love how easy it is to get contributions upstream with y’all

seems like just a flaky test, should be unrelated. I'll rerun that on the latest commit on

master

Hi! I was wondering when are you all planning to cut the next release? We will plan our telemetry changes accordingly

I'll aim to prep a release today. Checking some other PR's still to see if there are some ready ones.