Hey y'all! I'm new here :wave: :slightly_smiling_f...
# dev-metaflow
s
Hey y'all! I'm new here 👋 🙂 I noticed Metaflow's
uv
plugin only works on X86 instances right now, TODO in code here. We'd like to use ARM (Graviton) instances with
uv
. Is anyone working on this, or should I create a ticket and PR? The fix could be as simple as
Copy code
def _get_uv_url() -> str:
    """Return the uv release URL for the current platform architecture."""
    arch = platform.machine().lower()
    if arch in ("aarch64", "arm64"):
        return "<https://github.com/astral-sh/uv/releases/download/0.6.11/uv-aarch64-unknown-linux-gnu.tar.gz>"
    return "<https://github.com/astral-sh/uv/releases/download/0.6.11/uv-x86_64-unknown-linux-gnu.tar.gz>"
h
Hi PRs are welcome :) I haven't looked at the code but there may be other things that need to be changed
🙏 1
s
Ok thanks @hundreds-rainbow-67050! I actually noticed that there was a ticket already here github.com/Netflix/metaflow/issues/2642 and it has two pending PRs that address the issue. This one is already reviewed, just lacks addressing the feedback, but there's been no activity since Feb this year. Should I just pick it up from there?
h
Go for it
👍 1
s
Alright, here we go github.com/Netflix/metaflow/pull/3332 🙂 Happy to get feedback on this, my first PR on an open source project 😬 Quick TL;DR: I based off of the existing PR by
vyagh
and just addressed the outstanding feedback to clean up his tests wrt. conventions (and simplified them a little, e.g. parameterize)
👀 1
Thanks for the review! Iterated and addressed all feedback I think 🙂 Lemme know if it looks good, no rush of course